Port to GNOME 3.34 #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes & arrow functions. Tested on GNOME 3.32. Classes need to be overridden with vars to avoid the “That property was defined with 'let' or 'const' inside the module.” warning.
I had to accomodate the following GNOME Shell changes: * Slider switched to value property instead of methods. (https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/666) * Widgets themselves now inherit from actors. (https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/487) * Popup menu is GObject.Class so it cannot use constructor. (https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/499) * MetaShapedTexture no longer has get_size method, nor it can be cloned. (https://gitlab.gnome.org/GNOME/mutter/merge_requests/409) Additionally: * Changed the supported GNOME Shell versions to 3.34, as maintaining backwards compatibility would be too much work. * Removed fallbacks since we do not support GNOME ≤ 3.34 any more.
|
Perhaps it would be a good idea to convert all the listeners and emits to GObject properties connected together with Unfortunately, the data flows throughout almost all the modules so we would need to duplicate the properties everywhere.
I tried the following but apparently var PopupSliderMenuItem = GObject.registerClass({
Properties: {
'value': GObject.ParamSpec.double(
'value', 'value', 'value',
GObject.ParamFlags.READWRITE,
GLib.MINDOUBLE, GLib.MAXDOUBLE, 0,
},
}, class PopupSliderMenuItem extends PopupMenu.PopupBaseMenuItem {
…
this.slider.bind_property_full(
'value',
this,
'value',
GObject.BindingFlags.BIDIRECTIONAL,
(value) => deNormalizeRange(value, this.min, this.max, this.step),
(value) => normalizeRange(value, this.min, this.max, this.step)
); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can now use the extension successfully on GNOME 3.34. There are still some bugs to work out, though:
Attempting to call back into JSAPI during the sweeping phase of GC. This is most likely caused by not destroying a Clutter actor or Gtk+ widget with ::destroy signals connected, but can also be caused by using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked and the JS callback not invoked. The offending signal was destroy on Gjs_ExtensionRow 0x2ea3600.Does anyone have an idea how to solve these?
What has been done
I had to accomodate the following GNOME Shell changes:
Additionally: